Skip to content

Move dump_keyring.py to remove dep chia.util => chia.cmds #19600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

Move dump_keyring.py to remove dep chia.util => chia.cmds #19600

merged 1 commit into from
May 22, 2025

Conversation

richardkiss
Copy link
Contributor

Purpose:

The chia.util module currently depends upon chia.cmds and it shouldn't. This PR fixes that.

Current Behavior:

New Behavior:

Testing Notes:

@richardkiss richardkiss requested a review from a team as a code owner May 12, 2025 19:13
@richardkiss richardkiss added Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes labels May 12, 2025
aqk
aqk previously approved these changes May 12, 2025
View reviewed changes
arvidn
arvidn previously approved these changes May 12, 2025
View reviewed changes
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented May 12, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 14984189610

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 55 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-0.03%) to 91.226%
Files with Coverage Reduction New Missed Lines %
chia/daemon/server.py 1 83.46%
chia/full_node/pending_tx_cache.py 1 96.55%
chia/consensus/blockchain.py 2 94.56%
chia/full_node/full_node_api.py 2 85.15%
chia/full_node/full_node.py 2 88.23%
chia/server/node_discovery.py 2 82.29%
chia/timelord/timelord_launcher.py 2 90.71%
chia/rpc/rpc_server.py 3 88.24%
chia/server/server.py 4 82.51%
chia/farmer/farmer.py 7 73.44%
Totals Coverage Status
Change from base Build 14972754868: -0.03%
Covered Lines: 101203
Relevant Lines: 110818
💛 - Coveralls

@richardkiss richardkiss dismissed stale reviews from arvidn and aqk via 90a548e May 12, 2025 22:49
@richardkiss richardkiss requested review from aqk and arvidn May 21, 2025 21:53
@cmmarslender cmmarslender merged commit 386787f into Chia-Network:main May 22, 2025
703 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvidn arvidn arvidn approved these changes

@aqk aqk Awaiting requested review from aqk

Assignees
No one assigned
Labels
Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@richardkiss @aqk @arvidn @cmmarslender